Access: Minor Rework #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Marukesu can you resolve conflicts here? |
all the dbus handling is done in the portal already, let the register_id there instead of creating an full property for it in the dialog.
let the construct method deal only with the dialog construction
since the keybind is trigged by a user action, react to it as such by sending an cancel response back to the caller
this way, we don't miss if Close is called before we export the dialog
we can only fall here if the path the caller expect us to use is already used by an previous call, or different portal. since we cannot do much here, we forward the error to the caller. since falling to register the dialog don't cause issues to the portal daemon, the critical is replaced by a warning.
|
@danirabbit done |
danirabbit
reviewed
Jan 16, 2023
| @@ -75,27 +73,28 @@ public class Access.Dialog : Granite.MessageDialog { | |||
|
|
|||
| custom_bin.orientation = Gtk.Orientation.VERTICAL; | |||
| custom_bin.spacing = 6; | |||
| } | |||
|
|
|||
| public override void show () { | |||
There was a problem hiding this comment.
Can you explain why it's better to override show than to connect to realize? Is there an issue that this fixes?
There was a problem hiding this comment.
i don't think this should change the current behaviour, this is more a organization/simplification change (separate widget code from windowing code, reduce the number of functions used).
danirabbit
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minimal changes to the access classes, the more siginificant one is that we don't set skip_taskbar_hint anymore since that is a X11-only feature and actually could make find the dialog a bit hader if it was open as non-modal and another window take focus.