Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement screen cast portal #102

Merged
merged 26 commits into from
Jun 17, 2024
Merged

Implement screen cast portal #102

merged 26 commits into from
Jun 17, 2024

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Apr 4, 2024

Supports everything (of version 3 i think at least) now and shows a dialog where you can select what you want to record.

The only thing I'm not really sure about is what I'm supposed to do with the VIRTUAL input source. IIUC this is just the whole virtual display across all monitors. Should this be shown as an extra entry under monitors or somewhere separate? I'm currently showing it separate as "Entire Display"

Todo:

  • set parent window
  • do something with virtual
  • Make the dialog look nice (Meh, help appreciated :))

Follow ups:

  • Support session save and restore, i.e. upgrade the version to 4

@leolost2605 leolost2605 marked this pull request as ready for review June 16, 2024 17:27
@leolost2605
Copy link
Member Author

I've tested this with Kooha and with mutter 46

@leolost2605 leolost2605 requested a review from a team June 16, 2024 17:28
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with ASHPD Demo and I can confirm that monitor and window screen capture is working! Nice job :)

@danirabbit danirabbit enabled auto-merge (squash) June 17, 2024 17:34
@danirabbit danirabbit merged commit ad05247 into main Jun 17, 2024
4 checks passed
@danirabbit danirabbit deleted the leolost/screen-casting branch June 17, 2024 17:35
@danirabbit danirabbit mentioned this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants