Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pantheon.portal: remove deprecated UseIn key #100

Closed
wants to merge 1 commit into from

Conversation

danirabbit
Copy link
Member

Fixes #96

@danirabbit danirabbit requested a review from a team March 26, 2024 19:10
@bobby285271
Copy link
Member

bobby285271 commented Mar 27, 2024

flatpak/xdg-desktop-portal@8e243eb suggests that this is warned because user's portal config is broken, not because portal implementations should remove it, it is probably still a good idea to preserve this for x-d-p < 1.17 and this is still kept in e.g. x-d-p-gtk for example.

I don't experience the original issue on NixOS. A G_MESSAGES_DEBUG=all /usr/libexec/xdg-desktop-portal run can probably provide some hint how configs are loaded and chosen. But since the issue is opened 2 months ago and elementary/default-settings#303 was merged 1 week ago, I would really expect that PR fixing the original issue 🤔

@danirabbit
Copy link
Member Author

Ah okay. Gonna close this then :)

@danirabbit danirabbit closed this Mar 27, 2024
@danirabbit danirabbit deleted the danirabbit/rm-usein branch March 27, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UseIn key is deprecated
2 participants