Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: Use rounded arrow for browser-download #1209

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

newhoa
Copy link
Collaborator

@newhoa newhoa commented Jun 20, 2023

Completes part of Issue #922 (Make all of the arrows consistent)

@newhoa
Copy link
Collaborator Author

newhoa commented Jun 20, 2023

Arrow might be a little too low on 32px, any of these better?

Current

browser-download-pr1-current-too-low

Higher arrow
browser-download-pr1-prop-higher

Higher and wider arrow (I think this one might best?)
browser-download-pr1-prop-higher-wider

Any other feedback would be appreciated. I tried to stick as close as I could to the go-down and document-import icons.

@danirabbit
Copy link
Member

@newhoa these look really good, I think you're right about the 32px the higher and wider looks best to me

@newhoa newhoa force-pushed the browser-download-rounded-arrow branch from f42949b to 4034880 Compare June 20, 2023 23:03
@newhoa
Copy link
Collaborator Author

newhoa commented Jun 20, 2023

@newhoa these look really good, I think you're right about the 32px the higher and wider looks best to me

Ok thanks. Updated, should be good to go if everything else looks good!

Completes part of Issue elementary#922 (Make all of the arrows consistent)
@newhoa newhoa force-pushed the browser-download-rounded-arrow branch from 4034880 to 31deb62 Compare June 20, 2023 23:05
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic 🎉

@danirabbit danirabbit merged commit 18a2159 into elementary:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants