Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize 128px application-x-executable #1135

Merged
merged 9 commits into from
Sep 29, 2022
Merged

Modernize 128px application-x-executable #1135

merged 9 commits into from
Sep 29, 2022

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Sep 28, 2022 •
edited
Loading

Make sure we use a different icon for binary file types vs fallback app icons. Use palette colors. Scale down "Windows" symbol

@danirabbit danirabbit mentioned this pull request Sep 28, 2022
Merged
2 tasks
@waldyrious waldyrious mentioned this pull request Sep 28, 2022
Merged
@danirabbit danirabbit marked this pull request as ready for review September 28, 2022 17:29
@danirabbit danirabbit requested a review from a team September 28, 2022 17:30
micahilbery
micahilbery approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@micahilbery micahilbery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@danirabbit danirabbit enabled auto-merge (squash) September 29, 2022 20:47
@danirabbit danirabbit merged commit f7ede70 into master Sep 29, 2022
@danirabbit danirabbit deleted the application-x-executables branch September 29, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahilbery micahilbery micahilbery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @micahilbery