Add show uri on window patch #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this patch works, but it makes "Open" and "Open With..." do the same thing. Not sure if that's acceptable or we want to remove the "Open with..." menuitem as well here |
|
Since it's using the default behaviour of OpenURI (stop to show the appchooser after selecting the same app 3 times). remove the "Open With…" button seems better. |
|
@Marukesu added a patch to remove the "Open With..." menuitem as well |
Marukesu
approved these changes
Dec 4, 2021
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses patch from https://gitlab.gnome.org/GNOME/file-roller/-/merge_requests/55 to solve one of the issues raised in #10