Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some media-keys from static to their normal versions #288

Merged
merged 5 commits into from
Oct 21, 2023
Merged

Move some media-keys from static to their normal versions #288

merged 5 commits into from
Oct 21, 2023

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Aug 17, 2023 •
edited
Loading

@lenemter lenemter mentioned this pull request Aug 17, 2023
Merged
@lenemter lenemter requested a review from a team August 17, 2023 15:07
@danirabbit
Copy link
Member

I think I'm going to kick this to the OS 8 project board since it seems like maybe we want some more lengthy testing here

zeebok
zeebok approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable start to start testing long term

@lenemter
Copy link
Member Author

Tested this again and it works as expected, so I'll merge this.

@lenemter lenemter merged commit 86ed77d into master Oct 21, 2023
3 checks passed
@lenemter lenemter deleted the lenemter/move-static branch October 21, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
OS 8
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multimedia buttons bindings are displayed as "Disabled"
3 participants
@lenemter @danirabbit @zeebok