Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not change document search results unexpectedly on focus in #1294

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Do not change document search results unexpectedly on focus in #1294

merged 2 commits into from
Mar 27, 2023

Conversation

jeremypw
Copy link
Collaborator

FIxes #1293

@jeremypw jeremypw added the Good First Issue Small, self-contained issue. Good for newcomers, and/or should be an easy fix. label Mar 26, 2023
@jeremypw jeremypw requested a review from a team March 27, 2023 11:16
danirabbit
danirabbit approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense and I can confirm it fixes the issue

@danirabbit danirabbit merged commit a06e33f into master Mar 27, 2023
@danirabbit danirabbit deleted the fix-focusin-recreatesearchcontext branch March 27, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
Good First Issue Small, self-contained issue. Good for newcomers, and/or should be an easy fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search results change when document focused in
2 participants
@jeremypw @danirabbit