Implement option to show files with unknown characters as new document #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeebok
previously approved these changes
Mar 17, 2023
|
On initial opening of corrupted file: After loading as text: Attempt to load file with no read permission: |
|
@danirabbit You may wish to comment on the text or other design matters. |
danirabbit
reviewed
Mar 17, 2023
# Conflicts: # src/Services/Document.vala
danirabbit
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1282
It turns out we are loading corrupt or non-text files into a buffer anyway and I presume
Gtk.SourceFileLoadercan be trusted to produce a valid (if not very readable) text file. This PR adds an option to the AlertView to show what was loaded when a non-empty string was produced. Because we do not want the original file to be inadvertently overwritten, the loaded text is used to create a new document.When no text is loaded we can assume it was because the content of the file was not accessible due to permissions or other problem (an empty readable file is always valid). The text and presence of the option is therefore modified depending on whether any text was loaded.