Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make symbol outline aware of follow-system-style setting #1265

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Make symbol outline aware of follow-system-style setting #1265

merged 3 commits into from
Feb 7, 2023

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Feb 3, 2023 •
edited
Loading

Fixes #1263

Just copied the corresponding code from DocumentView.

@Marukesu
Copy link
Contributor

Marukesu commented Feb 3, 2023

I think this is missing a check for when the system style changes, no?

@jeremypw jeremypw marked this pull request as draft February 4, 2023 09:15
@jeremypw
Copy link
Collaborator Author

jeremypw commented Feb 4, 2023

@Marukesu Thanks for pointing that out! I will not have time to fix immediately so converting to draft.

@jeremypw
Copy link
Collaborator Author

jeremypw commented Feb 4, 2023

Made use of the style-changed signal to avoid repeating some code and ensure style of outline and document match.

@jeremypw jeremypw marked this pull request as ready for review February 7, 2023 10:10
Marukesu
Marukesu approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@Marukesu Marukesu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code works as expected.

@jeremypw jeremypw merged commit 78e66a0 into master Feb 7, 2023
@jeremypw jeremypw deleted the fix-symbollist-systemstyle branch February 7, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marukesu Marukesu Marukesu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Symbol outline does not respect system style
2 participants
@jeremypw @Marukesu