Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Alpine Linux Synapse Package Maintainer within installation.md #17846

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

jahway603
Copy link
Contributor

Update Alpine Linux Synapse Package Maintainer within installation.md as it is outdated.

Pull Request Checklist

  • Pull request is based on the develop branch
  • [N/A] Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

Update Alpine Linux Synapse Package Maintainer within installation.md as it is outdated.
@jahway603 jahway603 requested a review from a team as a code owner October 17, 2024 19:37
@CLAassistant
Copy link

CLAassistant commented Oct 17, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot deployed to PR Documentation Preview October 17, 2024 19:39 Active
Copy link
Contributor

@MadLittleMods MadLittleMods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jahway603 This is just waiting on the CLA being signed

@@ -157,7 +157,7 @@ sudo pip install py-bcrypt

#### Alpine Linux

6543 maintains [Synapse packages for Alpine Linux](https://pkgs.alpinelinux.org/packages?name=synapse&branch=edge) in the community repository. Install with:
Jahway603 maintains [Synapse packages for Alpine Linux](https://pkgs.alpinelinux.org/packages?name=synapse&branch=edge) in the community repository. Install with:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm this, https://pkgs.alpinelinux.org/packages?name=synapse&branch=edge indicates that jahway603 is a maintainer

@@ -157,7 +157,7 @@ sudo pip install py-bcrypt

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs a changelog, we can just create 17846.doc

Update maintainer of Alpine Linux Synapse package.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jahway603 Can you add this?

@jahway603
Copy link
Contributor Author

@jahway603 This is just waiting on the CLA being signed

I've signed the CLA before in this PR #17140

@MadLittleMods
Copy link
Contributor

@jahway603 This is just waiting on the CLA being signed

I've signed the CLA before in this PR #17140

hmm, you seem to be right as far as I can tell (same email in the patch for this PR and the one you linked). When I click "recheck" it doesn't seem to do anything.

@devonh (maintainer ping) any idea?

@devonh
Copy link
Member

devonh commented Nov 5, 2024

@jahway603 This is just waiting on the CLA being signed

I've signed the CLA before in this PR #17140

hmm, you seem to be right as far as I can tell (same email in the patch for this PR and the one you linked). When I click "recheck" it doesn't seem to do anything.

@devonh (maintainer ping) any idea?

It looks like the CLA was updated to v2.0 on October 10, 2024.
@jahway603 you will need to sign the latest version of the CLA.

@jahway603
Copy link
Contributor Author

@devonh how do I do that "safely"? I remember I was able to not dox myself on GitHub last time I signed the CLA in PR #17140.

@jahway603
Copy link
Contributor Author

This PR relates to Issue #17977.

@devonh
Copy link
Member

devonh commented Dec 4, 2024

@devonh how do I do that "safely"? I remember I was able to not dox myself on GitHub last time I signed the CLA in PR #17140.

Following the link from the CLA Assistant above is "safe".
The information provided isn't public and is private to Element.

@devonh
Copy link
Member

devonh commented Dec 5, 2024

Looks like CI is failing due to a missing changelog entry.
Could you add changelog.d/17846.misc with something like Update Alpine Linux Synapse Package Maintainer.?

@github-actions github-actions bot deployed to PR Documentation Preview December 10, 2024 21:06 Active
@devonh
Copy link
Member

devonh commented Dec 10, 2024

Thanks for jumping through all the hoops and getting this changed :)

@devonh devonh merged commit 5da7081 into element-hq:develop Dec 10, 2024
33 checks passed
@jahway603
Copy link
Contributor Author

Fixes Issue #17977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants