Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix joined_rooms/joined_room_ids usage #17208

Merged
merged 2 commits into from
May 16, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix joined_rooms/joined_room_ids usage
This change was introduced in #17203

But then #17207 was
reverted which brought back usage `joined_rooms` that needed to be
updated. Wasn't caught because `develop` wasn't up to date before merging
MadLittleMods committed May 16, 2024
commit 59da375521d2090b6f729cc55ba2f83745483559
2 changes: 1 addition & 1 deletion synapse/handlers/sync.py
Original file line number Diff line number Diff line change
@@ -1875,7 +1875,7 @@ async def _generate_sync_entry_for_device_list(
# or if the changed user is the syncing user (as we always
# want to include device list updates of their own devices).
if user_id == changed_user_id or any(
rid in joined_rooms for rid in entries
rid in joined_room_ids for rid in entries
):
users_that_have_changed.add(changed_user_id)
else: