Merge remote-tracking branch 'origin/release-v1.101' into develop

element-hq · Feb 9, 2024 · ea1b309 · ea1b309
2 parents bfa93d1 + 02a1470
commit ea1b309
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/changelog.d/16893.bugfix b/changelog.d/16893.bugfix
@@ -0,0 +1 @@
+Fix performance regression when fetching auth chains from the DB. Introduced in v1.100.0.
diff --git a/synapse/storage/databases/main/event_federation.py b/synapse/storage/databases/main/event_federation.py
@@ -310,7 +310,7 @@ def _get_auth_chain_ids_using_cover_index_txn(
         # Add all linked chains reachable from initial set of chains.
         chains_to_fetch = set(event_chains.keys())
         while chains_to_fetch:
-            batch2 = tuple(itertools.islice(chains_to_fetch, 100))
+            batch2 = tuple(itertools.islice(chains_to_fetch, 1000))
             chains_to_fetch.difference_update(batch2)
             clause, args = make_in_list_sql_clause(
                 txn.database_engine, "origin_chain_id", batch2
@@ -593,7 +593,7 @@ def fetch_chain_info(events_to_fetch: Collection[str]) -> None:
         # the loop)
         chains_to_fetch = set(seen_chains)
         while chains_to_fetch:
-            batch2 = tuple(itertools.islice(chains_to_fetch, 100))
+            batch2 = tuple(itertools.islice(chains_to_fetch, 1000))
             clause, args = make_in_list_sql_clause(
                 txn.database_engine, "origin_chain_id", batch2
             )
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix performance regression when fetching auth chains from the DB. Introduced in v1.100.0.