Skip to content

Commit

Permalink
Sliding Sync: Fix limited response description (make accurate) (#17507
Browse files Browse the repository at this point in the history
)
  • Loading branch information
MadLittleMods authored Jul 31, 2024
1 parent 46de0ee commit 1d61862
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions changelog.d/17507.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update the `limited` field description in the Sliding Sync response to accurately describe what it actually represents.
4 changes: 2 additions & 2 deletions synapse/types/handlers/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,8 @@ class RoomResult:
absent on joined/left rooms
prev_batch: A token that can be passed as a start parameter to the
`/rooms/<room_id>/messages` API to retrieve earlier messages.
limited: True if their are more events than fit between the given position and now.
Sync again to get more.
limited: True if there are more events than `timeline_limit` looking
backwards from the `response.pos` to the `request.pos`.
num_live: The number of timeline events which have just occurred and are not historical.
The last N events are 'live' and should be treated as such. This is mostly
useful to determine whether a given @mention event should make a noise or not.
Expand Down

0 comments on commit 1d61862

Please sign in to comment.