Remove Generator in _purge_unreferenced_state_groups twice (#17815)

Context: matrix-org/synapse#15439 (#15439) Also see discussion in #17813
element-hq · Oct 31, 2024 · 034d472 · 034d472
1 parent 0c429fa
commit 034d472
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/changelog.d/17815.bugfix b/changelog.d/17815.bugfix
@@ -0,0 +1 @@
+Avoid lost data on some database query retries.
diff --git a/synapse/storage/databases/state/store.py b/synapse/storage/databases/state/store.py
@@ -804,11 +804,11 @@ def _purge_unreferenced_state_groups(
         logger.info("[purge] removing redundant state groups")
         txn.execute_batch(
             "DELETE FROM state_groups_state WHERE state_group = ?",
-            ((sg,) for sg in state_groups_to_delete),
+            [(sg,) for sg in state_groups_to_delete],
         )
         txn.execute_batch(
             "DELETE FROM state_groups WHERE id = ?",
-            ((sg,) for sg in state_groups_to_delete),
+            [(sg,) for sg in state_groups_to_delete],
         )
 
     @trace
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Avoid lost data on some database query retries.