Privacy: Remove the bind true flag from 3PID adds in settings (#3254)

element-hq · Sep 24, 2019 · 8de195d · 8de195d
1 parent 272bfd9
commit 8de195d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -11,6 +11,7 @@ Features:
  - Privacy: Make clear that device names are publicly readable (#3265)
  - Privacy: Email help text on registration should be updated without binding (#3278)
  - Privacy: Use wellknown to discover the IS of a HS (#3283)
+ - Privacy: Remove the bind true flag from 3PID adds in settings (#3254)
 
 Improvements:
  -

diff --git a/vector/src/main/java/im/vector/activity/PhoneNumberVerificationActivity.java b/vector/src/main/java/im/vector/activity/PhoneNumberVerificationActivity.java
@@ -186,7 +186,7 @@ public void onUnexpectedError(Exception e) {
     }
 
     private void registerAfterPhoneNumberValidation(final ThreePid pid) {
-        mSession.getMyUser().add3Pid(pid, true, new ApiCallback<Void>() {
+        mSession.getMyUser().add3Pid(pid, false, new ApiCallback<Void>() {
             @Override
             public void onSuccess(Void info) {
                 Intent intent = new Intent();

diff --git a/vector/src/main/java/im/vector/fragments/VectorSettingsPreferencesFragment.kt b/vector/src/main/java/im/vector/fragments/VectorSettingsPreferencesFragment.kt
@@ -1910,7 +1910,8 @@ class VectorSettingsPreferencesFragment : PreferenceFragmentCompat(), SharedPref
                     .setTitle(R.string.account_email_validation_title)
                     .setMessage(R.string.account_email_validation_message)
                     .setPositiveButton(R.string._continue) { _, _ ->
-                        mSession.myUser.add3Pid(pid, true, object : ApiCallback<Void> {
+                        // We do not bind anymore emails when registering, so let's do the same here
+                        mSession.myUser.add3Pid(pid, false, object : ApiCallback<Void> {
                             override fun onSuccess(info: Void?) {
                                 it.runOnUiThread {
                                     hideLoadingView()