Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: make Compose RTE styles public #22

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

jmartinesp
Copy link
Member

This is needed to avoid warnings when used in a project with Kotlin 2.0, since now the copy method will also have the same visibility as the main constructor (internal, for these classes).

@jmartinesp jmartinesp requested a review from bmarty October 3, 2024 14:42
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.33%. Comparing base (29b8b76) to head (7286ae7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   90.16%   89.33%   -0.83%     
==========================================
  Files         179      104      -75     
  Lines       22240    18008    -4232     
  Branches      291      291              
==========================================
- Hits        20053    16088    -3965     
+ Misses       2184     1917     -267     
  Partials        3        3              
Flag Coverage Δ
uitests ?
uitests-ios ?
unittests 89.33% <ø> (+0.28%) ⬆️
unittests-ios ?
unittests-react 88.25% <ø> (ø)
unittests-rust 89.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp added Android and removed Android labels Oct 3, 2024
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jmartinesp jmartinesp merged commit ac5ecd0 into main Oct 3, 2024
8 of 10 checks passed
@jmartinesp jmartinesp deleted the android/make-compose-rte-styles-public branch October 3, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants