-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for HTTP proxy: replace the HTTP client with reqwest #3424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with Cloudflare Pages
|
sandhose
force-pushed
the
quenting/reqwest
branch
from
October 25, 2024 15:31
fa89c23
to
baab4a0
Compare
sandhose
added
the
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
label
Dec 16, 2024
sandhose
changed the title
Replace the HTTP client with reqwest
Support for HTTP proxy: replace the HTTP client with reqwest
Dec 16, 2024
sandhose
added
T-Enhancement
New feature of request
and removed
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
labels
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the old stack of tower layers with just
reqwest
. This has many advantages, like:I also took the opportunity to simplify A LOT
mas-oidc-client
to only the things we use, instead of making it so generic, which removes a lot of codeThe only downside I see, is that it's a lot harder to test fake client requests.
wiremock
works well, but can't listen for HTTPS traffic.One important thing to shout about in the changelog, is that we now support proxies, using the following environment variables:
http_proxy
/HTTP_PROXY
for proxying HTTP requestshttps_proxy
/HTTPS_PROXY
for proxying HTTPS requests (note that this won't bypass CA verification, so stuff likemitmproxy
require trusting an extra CA)all_proxy
/ALL_PROXY
for bothno_proxy
/NO_PROXY
to add exclusions of hosts/IPs which shouldn't be proxiedIt supports both HTTP and SOCKS5 proxies.