Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote echo arriving before /send returns can cause stuck message #289

Closed
bwindels opened this issue Mar 24, 2021 · 3 comments · Fixed by #321
Closed

Remote echo arriving before /send returns can cause stuck message #289

bwindels opened this issue Mar 24, 2021 · 3 comments · Fixed by #321
Labels
bug Something isn't working

Comments

@bwindels
Copy link
Contributor

bwindels commented Mar 24, 2021

See event id $Gf2vrm-QNmQy0Z9uuSF5jxTFqifbcFsACFzpIcrcfHM in bwindels-stuck-message-hydrogen-logs-1616578957490.json

The pending event seems to be removed by the remote echo, but then added again when /send returns? Perhaps PendingEventStore.exists has a bug?

@bwindels bwindels added the bug Something isn't working label Mar 24, 2021
@bwindels
Copy link
Contributor Author

the stuck message had queueIndex:1, and when sending another message some many minutes later, the stuck message got replaced by the new message (who would also have queueIndex:1, so the count was wrong, perhaps because in-memory wasn't in sync with storage?)

@bwindels
Copy link
Contributor Author

bwindels commented Apr 6, 2021

Hit this again, see http://localhost:3000/scripts/logviewer/#2933/4/1/0 and http://localhost:3000/scripts/logviewer/#2935/0 in log bwindels-hydrogen-logs-1617642134956.json

@bwindels
Copy link
Contributor Author

bwindels commented Apr 8, 2021

this is the pending event emitting an update for status after send completes, which calls SortedArray.set which adds the pending event again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant