Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the media browser feature 🖼️ #3642

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Conversation

pixlwave
Copy link
Member

This PR makes the following changes:

  • Moves the download indicator from a toast to a custom overlay on the screen.
  • Localises a handful of strings that were waiting for confirmation (adding a download error state).
  • Removes the feature flag for the media browser.
  • Updates the SDK to 0.9.0 ready for release.

@pixlwave pixlwave requested a review from a team as a code owner December 19, 2024 13:28
@pixlwave pixlwave requested review from stefanceriu and removed request for a team December 19, 2024 13:28
Copy link

github-actions bot commented Dec 19, 2024

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against b5b63c1

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super duper cool! 👏

@pixlwave pixlwave added the pr-feature for a new feature label Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
908 1 907 0
View the top 1 failed tests by shortest run time
PreviewTests test_loginScreen()
Stack Traces | 4.23s run time
failed - Snapshot "matrix.org" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_loginScreen-iPhone-16-en-GB.matrix-org.png"
@+
"file:.../tmp/PreviewTests/test_loginScreen-iPhone-16-en-GB.matrix-org.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8511963 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@pixlwave pixlwave enabled auto-merge (squash) December 19, 2024 13:57
@pixlwave pixlwave merged commit 3aa7edc into develop Dec 19, 2024
8 checks passed
@pixlwave pixlwave deleted the doug/media-gallery-cleanup branch December 19, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants