Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder timeline item menu options #3640

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Reorder timeline item menu options #3640

merged 1 commit into from
Dec 19, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-change for updates to an existing feature label Dec 19, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner December 19, 2024 07:43
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team December 19, 2024 07:43
Copy link

Warnings
⚠️ Please provide a description for this PR.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 06ff0dc

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.46%. Comparing base (e7cc807) to head (06ff0dc).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...View/ItemMenu/TimelineItemMenuActionProvider.swift 71.42% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3640   +/-   ##
========================================
  Coverage    78.45%   78.46%           
========================================
  Files          788      788           
  Lines        66643    66642    -1     
========================================
  Hits         52288    52288           
+ Misses       14355    14354    -1     
Flag Coverage Δ
unittests 70.18% <71.42%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stefanceriu stefanceriu merged commit 21a1593 into develop Dec 19, 2024
15 checks passed
@stefanceriu stefanceriu deleted the stefan/3639 branch December 19, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants