Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the save action when previewing media. #3630

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

pixlwave
Copy link
Member

Images and videos are saved to the photo library, files ask the user to choose a directory to save them into.

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-17.at.12.56.31.mp4

@pixlwave pixlwave requested a review from a team as a code owner December 17, 2024 12:57
@pixlwave pixlwave requested review from stefanceriu and removed request for a team December 17, 2024 12:57
@pixlwave pixlwave added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
908 3 905 0
View the full list of 3 ❄️ flaky tests
PreviewTests test_timelineMediaPreviewDetailsView()

Flake rate in main: 25.45% (Passed 82 times, Failed 28 times)

Stack Traces | 2.02s run time
failed - Snapshot "Image" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_timelineMediaPreviewDetailsView-iPhone-16-pseudo.Image.png"
@+
"file:.../tmp/PreviewTests/test_timelineMediaPreviewDetailsView-iPhone-16-pseudo.Image.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9949837 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_userProfileScreen()

Flake rate in main: 14.29% (Passed 24 times, Failed 4 times)

Stack Traces | 2.2s run time
failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9031372 is less than required 1.0
The lowest perceptual color precision 0.31062502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 10.00% (Passed 90 times, Failed 10 times)

Stack Traces | 2.65s run time
failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.848999 is less than required 1.0
The lowest perceptual color precision 0.0 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 👌

Copy link

@pixlwave pixlwave requested a review from stefanceriu December 17, 2024 15:47
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑 it!

@pixlwave pixlwave merged commit 2a865ce into develop Dec 17, 2024
13 checks passed
@pixlwave pixlwave deleted the doug/media-preview-save branch December 17, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants