Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix state change commented by mistake and simplify snapshot test setup #3627

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

stefanceriu
Copy link
Member

… (+ a couple of warnings)

@stefanceriu stefanceriu added the pr-bugfix for bug fix label Dec 17, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner December 17, 2024 07:31
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team December 17, 2024 07:31
@@ -130,8 +130,8 @@ class MediaEventsTimelineScreenViewModel: MediaEventsTimelineScreenViewModelType

state.groups = newGroups

state.isBackPaginating = (timelineViewState.timelineState.paginationState.backward == .paginating)
// state.hasReachedTimelineStart = (timelineViewState.timelineState.paginationState.backward == .timelineEndReached)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committed this by mistake when trying to fix the snapshot tests yesterday

Copy link

github-actions bot commented Dec 17, 2024

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 85bec16

Copy link

codecov bot commented Dec 17, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
902 1 901 0
View the top 1 failed tests by shortest run time
PreviewTests test_settingsScreen()
Stack Traces | 3.02s run time
failed - Snapshot does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_settingsScreen-iPhone-16-en-GB.1.png"
@+
"file:.../tmp/PreviewTests/test_settingsScreen-iPhone-16-en-GB.1.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.85009766 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@stefanceriu stefanceriu force-pushed the stefan/mediaGalleryEmptyStateFix branch from 4cfbb60 to 85bec16 Compare December 17, 2024 08:35
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stefanceriu stefanceriu merged commit 598e604 into develop Dec 17, 2024
13 checks passed
@stefanceriu stefanceriu deleted the stefan/mediaGalleryEmptyStateFix branch December 17, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants