Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated room details design #3626

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Dec 16, 2024

No description provided.

@Velin92 Velin92 requested a review from a team as a code owner December 16, 2024 16:51
@Velin92 Velin92 requested review from pixlwave and removed request for a team December 16, 2024 16:51
Copy link

github-actions bot commented Dec 16, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 9380291

@Velin92 Velin92 added the pr-change for updates to an existing feature label Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
904 3 901 0
View the top 1 failed tests by shortest run time
PreviewTests test_userProfileScreen()
Stack Traces | 2.9s run time
failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9031372 is less than required 1.0
The lowest perceptual color precision 0.31062502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)
View the full list of 2 ❄️ flaky tests
PreviewTests test_timelineMediaPreviewDetailsView()

Flake rate in main: 23.53% (Passed 78 times, Failed 24 times)

Stack Traces | 1.28s run time
failed - Snapshot "Image" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_timelineMediaPreviewDetailsView-iPhone-16-pseudo.Image.png"
@+
"file:.../tmp/PreviewTests/test_timelineMediaPreviewDetailsView-iPhone-16-pseudo.Image.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9949837 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 10.42% (Passed 86 times, Failed 10 times)

Stack Traces | 2.45s run time
failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.848999 is less than required 1.0
The lowest perceptual color precision 0.0 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@Velin92 Velin92 force-pushed the mauroromito/room_details_moving_actions branch 2 times, most recently from 16d06c3 to e1b83aa Compare December 16, 2024 17:22
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Velin92 Velin92 enabled auto-merge (squash) December 16, 2024 17:36
@Velin92 Velin92 force-pushed the mauroromito/room_details_moving_actions branch from ffc94d2 to 9380291 Compare December 17, 2024 11:20
@Velin92 Velin92 merged commit 1496d47 into develop Dec 17, 2024
8 checks passed
@Velin92 Velin92 deleted the mauroromito/room_details_moving_actions branch December 17, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants