Rework the presentation of the media browser quick look view to use SwiftUI. #3619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
force-pushed
the
doug/media-preview-presentation
branch
from
ef78691 to
443d9df
Compare
pixlwave
added
the
pr-wip
pixlwave
changed the title
Velin92
approved these changes
Dec 16, 2024
Velin92
reviewed
Dec 16, 2024
| @@ -1581,8 +1581,8 @@ class RoomFlowCoordinator: FlowCoordinatorProtocol { | |||
| MXLog.error("Unable to present room timeline for event \(itemID)") | |||
| return | |||
| } | |||
| stateMachine.tryEvent(.dismissMediaEventsTimeline) | |||
| stateMachine.tryEvent(.presentRoom(presentationAction: .eventFocus(.init(eventID: eventID, shouldSetPin: false)))) | |||
| stateMachine.tryEvent(.presentRoom(presentationAction: .eventFocus(.init(eventID: eventID, shouldSetPin: false))), | |||
There was a problem hiding this comment.
couldn't we pass the animation directly in presentRoom as a variable?
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3619 +/- ##
===========================================
- Coverage 78.39% 78.33% -0.06%
===========================================
Files 782 787 +5
Lines 65661 66810 +1149
===========================================
+ Hits 51472 52336 +864
- Misses 14189 14474 +285
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that SwiftUI has a
navigationTransition(.zoom(…))option on iOS 18, putting the QuickLook controller inside our own NavigationStack with the right buttons is better, plus we get the matched animation instead of the preview coming from the button. This means the screen now has a Coordinator and is presented using the same system as the rest of the app. A follow-up will be to rename everything toTimelineMediaPreviewScreenor similar.A few small hitches:
iOS.18.1.mp4