-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security and privacy part 1 #3617
Conversation
67fc444
to
709e9a8
Compare
Generated by 🚫 Danger Swift against 8de4021 |
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👮♂️
ElementX/Sources/Screens/SecurityAndPrivacyScreen/SecurityAndPrivacyScreenCoordinator.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/SecurityAndPrivacyScreen/View/SecurityAndPrivacyScreen.swift
Show resolved
Hide resolved
...s/Sources/__Snapshots__/PreviewTests/test_roomDetailsScreen-iPhone-16-en-GB.Generic-Room.png
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/SecurityAndPrivacyScreen/View/SecurityAndPrivacyScreen.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/SecurityAndPrivacyScreen/SecurityAndPrivacyScreenViewModel.swift
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
I have committed so far everything that ca be done without requiring another PR from the SDK that is in WIP too, so that we can split this work into smaller pieces, that are not blocked, instead of having a huge PR that is awaiting for an SDK PR to be merged in main.
This adds a new option for non DM rooms to manage the security and privacy settings, so far it's using the same FF as knocking, but we may change this later and use a new FF in case we want to ship this feature separately.