Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security and privacy part 1 #3617

Merged
merged 6 commits into from
Dec 13, 2024
Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Dec 13, 2024

I have committed so far everything that ca be done without requiring another PR from the SDK that is in WIP too, so that we can split this work into smaller pieces, that are not blocked, instead of having a huge PR that is awaiting for an SDK PR to be merged in main.

This adds a new option for non DM rooms to manage the security and privacy settings, so far it's using the same FF as knocking, but we may change this later and use a new FF in case we want to ship this feature separately.

@Velin92 Velin92 requested a review from a team as a code owner December 13, 2024 16:02
@Velin92 Velin92 requested review from stefanceriu and pixlwave and removed request for a team December 13, 2024 16:02
@Velin92 Velin92 force-pushed the mauroromito/security_and_privacy branch from 67fc444 to 709e9a8 Compare December 13, 2024 16:02
Copy link

github-actions bot commented Dec 13, 2024

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 8de4021

@Velin92 Velin92 added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Dec 13, 2024
@Velin92 Velin92 changed the title Security and privacy Security and privacy part 1 Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
887 1 886 0
View the top 1 failed tests by shortest run time
PreviewTests test_loginScreen()
Stack Traces | 5.35s run time
failed - Snapshot "matrix.org" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_loginScreen-iPhone-16-en-GB.matrix-org.png"
@+
"file:.../tmp/PreviewTests/test_loginScreen-iPhone-16-en-GB.matrix-org.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8511963 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👮‍♂️

@Velin92 Velin92 merged commit b11fbc6 into develop Dec 13, 2024
5 checks passed
@Velin92 Velin92 deleted the mauroromito/security_and_privacy branch December 13, 2024 17:29
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants