Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various media gallery related tweaks #3616

Merged
merged 8 commits into from
Dec 13, 2024

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Dec 13, 2024

  • simplify some previews
  • avoid showing empty media groups
  • add empty states for rooms that don't have any media
  • fix taps not working on media gallery files

@stefanceriu stefanceriu added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Dec 13, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner December 13, 2024 15:22
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team December 13, 2024 15:22
Copy link

github-actions bot commented Dec 13, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against ac70559

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! 😎

Copy link

codecov bot commented Dec 13, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
888 2 886 0
View the top 1 failed tests by shortest run time
RoomDetailsEditScreenViewModelTests testCanEdit()
Stack Traces | 1.21s run time
XCTAssertTrue failed (UnitTests/Sources/RoomDetailsEditScreenViewModelTests.swift:35)
View the full list of 1 ❄️ flaky tests
PreviewTests test_timelineMediaPreviewDetailsView()

Flake rate in main: 28.81% (Passed 42 times, Failed 17 times)

Stack Traces | 2.84s run time
failed - Snapshot "Image" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_timelineMediaPreviewDetailsView-iPhone-16-pseudo.Image.png"
@+
"file:.../tmp/PreviewTests/test_timelineMediaPreviewDetailsView-iPhone-16-pseudo.Image.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9949837 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@stefanceriu stefanceriu merged commit 78aa0e3 into develop Dec 13, 2024
13 checks passed
@stefanceriu stefanceriu deleted the stefan/mediaGallery-part-who-even-knows-anymore branch December 13, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants