Various danger swift rule tweaks #3615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stefanceriu
commented
Dec 13, 2024
stefanceriu
commented
- remove the ticket number check, it's noisy
- remove signoff now that we have cla checks
- fix description image attachments check
pixlwave
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Nice!
Want to update https://github.com/element-hq/element-x-ios/blob/develop/.github/PULL_REQUEST_TEMPLATE.md in the PR while we're at it?
* remove the ticket number check, it's noisy * remove signoff now that we have cla checks * fix description image attachments check
stefanceriu
force-pushed
the
stefan/tweakDanger
branch
from
3264d72 to
d2e67b7
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3615 +/- ##
===========================================
- Coverage 78.38% 78.34% -0.05%
===========================================
Files 779 779
Lines 65549 65634 +85
===========================================
+ Hits 51382 51420 +38
- Misses 14167 14214 +47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.