-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom media gallery views for files and voice messages #3610
Conversation
… content but only keep the bubble background instead of the whole TimelineStyler.
Generated by 🚫 Danger Swift against 23845ac |
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
4e0de2a
to
23845ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
private struct TimelineItemBubbleBackgroundModifier: ViewModifier { | ||
@Environment(\.timelineGroupStyle) private var timelineGroupStyle | ||
|
||
let timelineItem: EventBasedTimelineItemProtocol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the perspective of using this for previews, if we passed in the isOutgoing
boolean instead of the whole timeline item here, we could use this modifier in places like SwipeRightAction_Previews
, LongPressWithFeedback_Previews
and FormattedBodyText_Previews
and get rid of those made up ones.
...Tests/Sources/__Snapshots__/PreviewTests/test_mediaEventsTimelineScreen-iPad-en-GB.Files.png
Outdated
Show resolved
Hide resolved
...urces/Screens/MediaEventsTimelineScreen/View/TimelineViews/AudioFileEventsTimelineView.swift
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
This PR extracts the timeline item backgrounds from the BubbledStyler and into its own modifier so that it can be reused for the media gallery views.
It also introduces different views for the files, audios and voice messages making use of the above.