Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media gallery - support for files and voice messages #3605

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Dec 11, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner December 11, 2024 15:41
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team December 11, 2024 15:41
Copy link

github-actions bot commented Dec 11, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 184c7f1

Copy link

codecov bot commented Dec 11, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
882 1 881 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_timelineMediaPreviewDetailsView()

Flake rate in main: 17.65% (Passed 14 times, Failed 3 times)

Stack Traces | 1.93s run time
failed - Snapshot "Image" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_timelineMediaPreviewDetailsView-iPhone-16-en-GB.Image.png"
@+
"file:.../tmp/PreviewTests/test_timelineMediaPreviewDetailsView-iPhone-16-en-GB.Image.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9968624 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@stefanceriu stefanceriu force-pushed the stefan/mediaGallery-part3 branch from 7d57d17 to 6937929 Compare December 11, 2024 16:31
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@stefanceriu stefanceriu merged commit 114255c into develop Dec 12, 2024
8 checks passed
@stefanceriu stefanceriu deleted the stefan/mediaGallery-part3 branch December 12, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants