Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure the media preview screen based on the event and presentation. #3604

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

pixlwave
Copy link
Member

This PR uses a timeline item action provider to determine which actions will be included for a given item. It also expands the timeline kinds to include the 2 different presentation types we will have for a media timeline (it is still hard-coded for the media browser flow for now).

The actions still aren't hooked up to anything.

@pixlwave pixlwave requested a review from a team as a code owner December 11, 2024 13:11
@pixlwave pixlwave requested review from Velin92 and removed request for a team December 11, 2024 13:11
Copy link

github-actions bot commented Dec 11, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against e2f1fee

Copy link

Copy link

codecov bot commented Dec 11, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
879 1 878 0
View the top 1 failed tests by shortest run time
PreviewTests test_roomMemberDetailsScreen()
Stack Traces | 2.62s run time
failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.848999 is less than required 1.0
The lowest perceptual color precision 0.0 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pixlwave pixlwave added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Dec 11, 2024
@pixlwave pixlwave merged commit c827ab9 into develop Dec 11, 2024
9 of 10 checks passed
@pixlwave pixlwave deleted the doug/media-preview-actions branch December 11, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants