Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the RustSDK to v1.0.79; add a feature flag for the new rust side ClientBuilder::useEventCachePersistentStorage #3599

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-misc for other changes label Dec 10, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner December 10, 2024 15:43
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team December 10, 2024 15:43
Copy link

github-actions bot commented Dec 10, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against e997c38

… `ClientBuilder::useEventCachePersistentStorage`
@stefanceriu stefanceriu enabled auto-merge (rebase) December 10, 2024 16:01
Copy link

codecov bot commented Dec 10, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
879 1 878 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_joinRoomScreen()

Flake rate in main: 17.24% (Passed 24 times, Failed 5 times)

Stack Traces | 5.4s run time
failed - Snapshot "Unknown" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Unknown.png"
@+
"file:.../tmp/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Unknown.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.966095 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@stefanceriu stefanceriu merged commit df3e597 into develop Dec 10, 2024
8 checks passed
@stefanceriu stefanceriu deleted the stefan/sdkBump branch December 10, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants