-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the timeline media QuickLook modifier. #3593
Conversation
Not hooked up to any flows yet.
Generated by 🚫 Danger Swift against 4650dd2 |
ElementX/Sources/Screens/FilePreviewScreen/TimelineMediaPreviewController.swift
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3593 +/- ##
===========================================
- Coverage 78.68% 78.55% -0.13%
===========================================
Files 762 769 +7
Lines 64193 64854 +661
===========================================
+ Hits 50509 50946 +437
- Misses 13684 13908 +224
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all super clean and nicely decoupled, love it!
...entX/Sources/Screens/FilePreviewScreen/View/TimelineMediaPreviewRedactConfirmationView.swift
Outdated
Show resolved
Hide resolved
...entX/Sources/Screens/FilePreviewScreen/View/TimelineMediaPreviewRedactConfirmationView.swift
Show resolved
Hide resolved
...entX/Sources/Screens/FilePreviewScreen/View/TimelineMediaPreviewRedactConfirmationView.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/FilePreviewScreen/View/TimelineMediaPreviewDetailsView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/FilePreviewScreen/View/TimelineMediaPreviewDetailsView.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/FilePreviewScreen/TimelineMediaPreviewViewModel.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/FilePreviewScreen/TimelineMediaPreviewViewModel.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/FilePreviewScreen/TimelineMediaPreviewModels.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/FilePreviewScreen/TimelineMediaPreviewController.swift
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
This is an initial implementation, it isn't hooked up to anything yet. The changes are:
.timelineMediaQuickLook
view modifier that takes aTimelineMediaPreviewViewModel
. This includes a complete new stack, leaving the old.interactiveQuickLook
modifier in place for avatars etc.QLPreviewController
as in the designs.This is very much still a WIP (the toolbar button doesn't always show and has the wrong icon, the caption layout is funky at times), but given the size of this branch I'm opening a PR for this now and will iterate on it further before hooking it up to the timeline/new media browser.
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-09.at.12.54.52.mp4