Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the timeline media QuickLook modifier. #3593

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Dec 9, 2024

This is an initial implementation, it isn't hooked up to anything yet. The changes are:

  • Add a new .timelineMediaQuickLook view modifier that takes a TimelineMediaPreviewViewModel. This includes a complete new stack, leaving the old .interactiveQuickLook modifier in place for avatars etc.
  • This view model can be configured with multiple preview items so that you can swipe through a timeline of previews.
  • Add a few overlays to the QLPreviewController as in the designs.
  • Adds a button to display details about the media along with buttons to view/delete the message (not hooked up yet).

This is very much still a WIP (the toolbar button doesn't always show and has the wrong icon, the caption layout is funky at times), but given the size of this branch I'm opening a PR for this now and will iterate on it further before hooking it up to the timeline/new media browser.

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-09.at.12.54.52.mp4

@pixlwave pixlwave requested a review from a team as a code owner December 9, 2024 12:56
@pixlwave pixlwave requested review from stefanceriu and removed request for a team December 9, 2024 12:56
@pixlwave pixlwave added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 4650dd2

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 61.91904% with 254 lines in your changes missing coverage. Please review.

Project coverage is 78.55%. Comparing base (7254b6e) to head (4650dd2).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...PreviewScreen/TimelineMediaPreviewController.swift 0.00% 103 Missing ⚠️
...ens/FilePreviewScreen/TimelineMediaQuickLook.swift 13.79% 75 Missing ⚠️
...FilePreviewScreen/TimelineMediaPreviewModels.swift 66.37% 38 Missing ⚠️
...ePreviewScreen/TimelineMediaPreviewViewModel.swift 75.00% 13 Missing ⚠️
...wScreen/View/TimelineMediaPreviewDetailsView.swift 93.23% 9 Missing ⚠️
...meline/TimelineItems/RoomTimelineItemFactory.swift 0.00% 9 Missing ⚠️
...w/TimelineMediaPreviewRedactConfirmationView.swift 94.16% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3593      +/-   ##
===========================================
- Coverage    78.68%   78.55%   -0.13%     
===========================================
  Files          762      769       +7     
  Lines        64193    64854     +661     
===========================================
+ Hits         50509    50946     +437     
- Misses       13684    13908     +224     
Flag Coverage Δ
unittests 69.83% <61.91%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all super clean and nicely decoupled, love it!

Copy link

sonarqubecloud bot commented Dec 9, 2024

@pixlwave pixlwave merged commit b5605a5 into develop Dec 9, 2024
13 checks passed
@pixlwave pixlwave deleted the doug/timeline-media-preview branch December 9, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants