Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a Date for the timestamp in all timeline items. #3590

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Dec 6, 2024

The media browser will include inspectors that reveal e.g. the date an image was uploaded, so we can't do the conversion to a string in the factory any more.

This resulted in lots of snapshot updates 🫠

@pixlwave pixlwave requested a review from a team as a code owner December 6, 2024 11:41
@pixlwave pixlwave requested review from Velin92 and removed request for a team December 6, 2024 11:41
@pixlwave pixlwave added the pr-misc for other changes label Dec 6, 2024
@pixlwave pixlwave changed the title Use a Date for the timestamp in all timeline items. Use a Date for the timestamp in all timeline items. Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against be648d2

Copy link

codecov bot commented Dec 6, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
876 2 874 0
View the top 2 failed tests by shortest run time
PreviewTests test_serverSelection()
Stack Traces | 2.97s run time
failed - Snapshot does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_serverSelection-iPhone-16-en-GB.3.png"
@+
"file:.../tmp/PreviewTests/test_serverSelection-iPhone-16-en-GB.3.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.91864014 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
MediaUploadPreviewScreenViewModelTests testVideoUploadWithoutCaption()
Stack Traces | 10.9s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link

sonarqubecloud bot commented Dec 6, 2024

@pixlwave pixlwave merged commit a9e4837 into develop Dec 6, 2024
8 checks passed
@pixlwave pixlwave deleted the doug/timestamp-date branch December 6, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants