Media gallery

[stefanceriu]

This PR contains the initial work done for the new Media Gallery feature which is very much still a work in progress. We've decided to merge it early under a feature flag in order to avoid later conflicts.

This screen is following a novel architecture where 2 different TimelineViewModels are composed together under the MediaEventsTimelineScreenViewModel to provide the 2 separate sections. They're powered by a new RustSDK API that allows filtering room messages based on their type (introduced in 4365)

We're doing this in order to reuse most of the timeline logic we already had in play for the room screen and pinned events timeline. The UI on the other hand is completely custom and only makes use of the TimelineViewStates and related models.

I haven't bothered with cleaning up the commits as I intend to squash all of it on merge and they still might prove useful to see the evolution.

What's not working:

• only images and videos are supported, no separators, files, voice messages etc.
• gifs don't animate (yet)
• separators (even though not rendered) are still computed per day
• there are no empty states
• media cannot be enlarged once rendered in the grid
• and most likely quite a few other things

Simulator.Screen.Recording.-.iPhone.16.-.2024-12-05.at.15.47.52.mp4

[github-actions]

	Warnings
⚠️	This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️	Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️	You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against ad3f2c7

[codecov]

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
877	2	875	0

View the full list of 2 ❄️ flaky tests

PreviewTests test_userProfileScreen()

Flake rate in main: 19.30% (Passed 46 times, Failed 11 times)

Stack Traces | 2.13s run time

failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_userProfileScreen-iPhone-16-pseudo.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_userProfileScreen-iPhone-16-pseudo.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.892395 is less than required 1.0
The lowest perceptual color precision 0.31062502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 16.46% (Passed 66 times, Failed 13 times)

Stack Traces | 2.29s run time

failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.848999 is less than required 1.0
The lowest perceptual color precision 0.0 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

[pixlwave]

Very nice, I like the composition of view models like that, seems reasonable that we should do the same and pass the timeline view model into the room screen view model too at some point. 😎

[pixlwave]

Oh yeah, we should probably figure out if that ordering makes sense too, but that doesn't need to block this PR.

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarQube Cloud