Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added historical message error label string #3580

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Dec 3, 2024

No description provided.

@Velin92 Velin92 requested a review from a team as a code owner December 3, 2024 14:11
@Velin92 Velin92 requested review from pixlwave and removed request for a team December 3, 2024 14:11
Copy link

github-actions bot commented Dec 3, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 975b616

Copy link

sonarqubecloud bot commented Dec 3, 2024

Copy link

codecov bot commented Dec 3, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
874 1 873 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_joinRoomScreen()

Flake rate in main: 7.89% (Passed 70 times, Failed 6 times)

Stack Traces | 3.76s run time
failed - Snapshot "Unknown" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Unknown.png"
@+
"file:.../tmp/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Unknown.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.966095 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@Velin92 Velin92 added the pr-change for updates to an existing feature label Dec 3, 2024
@Velin92 Velin92 merged commit c566c64 into develop Dec 3, 2024
10 checks passed
@Velin92 Velin92 deleted the mauroromito/string_for_historical_messages branch December 3, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants