Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK 1.0.77 #3578

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Update SDK 1.0.77 #3578

merged 3 commits into from
Dec 3, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Dec 3, 2024

No description provided.

@Velin92 Velin92 requested a review from a team as a code owner December 3, 2024 09:45
@Velin92 Velin92 requested review from stefanceriu and removed request for a team December 3, 2024 09:45
Copy link

github-actions bot commented Dec 3, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 6ac57b4

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Velin92 Velin92 added the pr-misc for other changes label Dec 3, 2024
@Velin92 Velin92 enabled auto-merge (squash) December 3, 2024 10:00
Copy link

sonarqubecloud bot commented Dec 3, 2024

Copy link

codecov bot commented Dec 3, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
874 1 873 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 40.00% (Passed 6 times, Failed 4 times)

Stack Traces | 3.05s run time
failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.83825684 is less than required 1.0
The lowest perceptual color precision 0.148125 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@Velin92 Velin92 merged commit 4372048 into develop Dec 3, 2024
8 checks passed
@Velin92 Velin92 deleted the mauroromito/update_sdk_1.0.77 branch December 3, 2024 11:18
@@ -153,6 +153,9 @@ struct RoomTimelineItemFactory: RoomTimelineItemFactoryProtocol {
case .sentBeforeWeJoined:
encryptionType = .megolmV1AesSha2(sessionID: sessionID, cause: .sentBeforeWeJoined)
errorLabel = L10n.commonUnableToDecryptNoAccess
case .historicalMessage:
encryptionType = .megolmV1AesSha2(sessionID: sessionID, cause: .historicalMessage)
errorLabel = L10n.commonUnableToDecryptNoAccess
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a new string for that timeline.decryption_failure.historical_event_no_key_backup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants