-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Knock Logic #3573
Implement Knock Logic #3573
Conversation
ac1cbaf
to
db0f521
Compare
Generated by 🚫 Danger Swift against fd9abe6 |
❌ 3 Tests Failed:
View the full list of 3 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
f53a00a
to
eded98e
Compare
2bfd64e
to
ba3a0f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Left some minor comments but otherwise looks good to me!
ElementX/Sources/Screens/KnockRequestsListScreen/KnockRequestsListScreenViewModel.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/KnockRequestsListScreen/View/KnockRequestCell.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/KnockRequestsListScreen/KnockRequestsListScreenModels.swift
Show resolved
Hide resolved
58000f3
to
30d3c34
Compare
of the banner
improved code and the tests
and improved the knock requests tests for the room screen
so I renamed it also on the app side
30d3c34
to
fd9abe6
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳 🎉
Ready for review, but before merging it we need the following PR to be merged in main, on the SDK:
matrix-org/matrix-rust-sdk#4338
fixes #3422
Simulator.Screen.Recording.-.iPhone.16.-.2024-12-05.at.12.28.58.mp4