Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Knock Logic #3573

Merged
merged 18 commits into from
Dec 16, 2024
Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 29, 2024

Ready for review, but before merging it we need the following PR to be merged in main, on the SDK:
matrix-org/matrix-rust-sdk#4338

fixes #3422

Simulator.Screen.Recording.-.iPhone.16.-.2024-12-05.at.12.28.58.mp4

@Velin92 Velin92 requested a review from a team as a code owner November 29, 2024 15:26
@Velin92 Velin92 requested review from pixlwave and removed request for a team November 29, 2024 15:26
@Velin92 Velin92 force-pushed the mauroromito/implement_knock_requests_logic branch from ac1cbaf to db0f521 Compare November 29, 2024 15:28
@Velin92 Velin92 marked this pull request as draft November 29, 2024 15:28
Copy link

github-actions bot commented Nov 29, 2024

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.

Generated by 🚫 Danger Swift against fd9abe6

Copy link

codecov bot commented Nov 29, 2024

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
903 3 900 0
View the full list of 3 ❄️ flaky tests
PreviewTests test_timelineMediaPreviewDetailsView()

Flake rate in main: 25.33% (Passed 56 times, Failed 19 times)

Stack Traces | 1.41s run time
failed - Snapshot "Image" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_timelineMediaPreviewDetailsView-iPhone-16-en-GB.Image.png"
@+
"file:.../tmp/PreviewTests/test_timelineMediaPreviewDetailsView-iPhone-16-en-GB.Image.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9968624 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_joinRoomScreen()

Flake rate in main: 36.36% (Passed 28 times, Failed 16 times)

Stack Traces | 3.24s run time
failed - Snapshot "Unknown" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Unknown.png"
@+
"file:.../tmp/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Unknown.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9659729 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 12.33% (Passed 64 times, Failed 9 times)

Stack Traces | 4.34s run time
failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8544922 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@Velin92 Velin92 force-pushed the mauroromito/implement_knock_requests_logic branch from f53a00a to eded98e Compare December 3, 2024 16:53
@Velin92 Velin92 added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Dec 4, 2024
@Velin92 Velin92 requested a review from stefanceriu December 4, 2024 15:22
@Velin92 Velin92 force-pushed the mauroromito/implement_knock_requests_logic branch from 2bfd64e to ba3a0f2 Compare December 5, 2024 11:16
@Velin92 Velin92 marked this pull request as ready for review December 5, 2024 11:16
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Left some minor comments but otherwise looks good to me!

@Velin92 Velin92 force-pushed the mauroromito/implement_knock_requests_logic branch 3 times, most recently from 58000f3 to 30d3c34 Compare December 13, 2024 17:34
@Velin92 Velin92 force-pushed the mauroromito/implement_knock_requests_logic branch from 30d3c34 to fd9abe6 Compare December 16, 2024 13:54
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 🎉

@Velin92 Velin92 merged commit 45a630d into develop Dec 16, 2024
8 checks passed
@Velin92 Velin92 deleted the mauroromito/implement_knock_requests_logic branch December 16, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Receiving requests to join
2 participants