Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle media source validation more gracefully. #3571

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

pixlwave
Copy link
Member

Replace the fatalError with a throwing init and handle the errors on a case by case basis.

@pixlwave pixlwave requested a review from a team as a code owner November 29, 2024 11:28
@pixlwave pixlwave requested review from Velin92 and removed request for a team November 29, 2024 11:28
Copy link

github-actions bot commented Nov 29, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against babf170

Copy link

codecov bot commented Nov 29, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
874 1 873 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_userProfileScreen()

Flake rate in main: 17.65% (Passed 168 times, Failed 36 times)

Stack Traces | 2.02s run time
failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9031372 is less than required 1.0
The lowest perceptual color precision 0.31062502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@pixlwave pixlwave added the pr-bugfix for bug fix label Nov 29, 2024
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lgtm, thank you! 👍

@pixlwave pixlwave merged commit 49a94e0 into develop Nov 29, 2024
9 checks passed
@pixlwave pixlwave deleted the doug/throwing-media-source branch November 29, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants