Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait until the sync has stopped before marking a background task as complete. #3564

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Nov 27, 2024

Looking through some logs for #3478, there was an example where everything went wrong due to the task being marked as complete before the sync had stopped. Hopefully this should fix that issue.

@pixlwave pixlwave requested a review from a team as a code owner November 27, 2024 14:03
@pixlwave pixlwave requested review from Velin92 and removed request for a team November 27, 2024 14:03
Copy link

github-actions bot commented Nov 27, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against a96d2ca

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 78.58%. Comparing base (e70a95c) to head (a96d2ca).
Report is 6 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
ElementX/Sources/Application/AppCoordinator.swift 0.00% 17 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3564      +/-   ##
===========================================
- Coverage    78.61%   78.58%   -0.04%     
===========================================
  Files          757      757              
  Lines        63708    63713       +5     
===========================================
- Hits         50085    50066      -19     
- Misses       13623    13647      +24     
Flag Coverage Δ
unittests 69.71% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave added the pr-bugfix for bug fix label Nov 27, 2024
@pixlwave pixlwave merged commit 4869dcf into develop Nov 28, 2024
14 checks passed
@pixlwave pixlwave deleted the doug/stop-sync-completion branch November 28, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants