Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back missing send button when media captions are disabled. #3561

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

pixlwave
Copy link
Member

FF off FF on
Simulator Screenshot - iPhone 16 Pro - 2024-11-27 at 11 14 17 Simulator Screenshot - iPhone 16 Pro - 2024-11-27 at 11 14 43

@pixlwave pixlwave requested a review from a team as a code owner November 27, 2024 11:15
@pixlwave pixlwave requested review from Velin92 and removed request for a team November 27, 2024 11:15
Copy link

github-actions bot commented Nov 27, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 0936b31

@pixlwave pixlwave added the pr-bugfix for bug fix label Nov 27, 2024
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@pixlwave pixlwave merged commit e70a95c into develop Nov 27, 2024
9 checks passed
@pixlwave pixlwave deleted the doug/fix-send-buttn branch November 27, 2024 11:35
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.57%. Comparing base (be8c147) to head (0936b31).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...dPreviewScreen/View/MediaUploadPreviewScreen.swift 20.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3561      +/-   ##
===========================================
- Coverage    78.58%   78.57%   -0.02%     
===========================================
  Files          757      757              
  Lines        63698    63708      +10     
===========================================
- Hits         50060    50057       -3     
- Misses       13638    13651      +13     
Flag Coverage Δ
unittests 69.70% <20.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants