Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the presentation of QuickLook when viewing logs on macOS. #3556

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

pixlwave
Copy link
Member

Before: Not interactive

Screen.Recording.2024-11-26.at.12.22.42.pm.mov

Now: Interactive

Screen.Recording.2024-11-26.at.12.52.59.pm.mov

@pixlwave pixlwave added the pr-bugfix for bug fix label Nov 26, 2024
@pixlwave pixlwave requested a review from a team as a code owner November 26, 2024 12:54
@pixlwave pixlwave requested review from Velin92 and removed request for a team November 26, 2024 12:54
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against d2111e4

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 78.62%. Comparing base (03aaf84) to head (d2111e4).
Report is 3 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...es/FlowCoordinators/BugReportFlowCoordinator.swift 0.00% 12 Missing ⚠️
...Screens/LogViewerScreen/View/LogViewerScreen.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3556      +/-   ##
===========================================
- Coverage    78.65%   78.62%   -0.03%     
===========================================
  Files          757      757              
  Lines        63637    63788     +151     
===========================================
+ Hits         50055    50156     +101     
- Misses       13582    13632      +50     
Flag Coverage Δ
unittests 69.71% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 3f0f442 into develop Nov 26, 2024
14 checks passed
@pixlwave pixlwave deleted the doug/macos-logs branch November 26, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants