Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move timeline item tap gestures to the items themselves instead of the bubbled styler #3553

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

stefanceriu
Copy link
Member

While not much came out of the UIGestureRecognizerRepresentable prototypes we can at least move the normal tap to within the cells themselves. This will for example fix images opening in full screen when tapping on the caption text.

@stefanceriu stefanceriu requested a review from a team as a code owner November 25, 2024 09:16
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team November 25, 2024 09:16
Copy link

github-actions bot commented Nov 25, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against aeffce7

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 59.52381% with 17 lines in your changes missing coverage. Please review.

Project coverage is 78.58%. Comparing base (fe984a1) to head (aeffce7).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/VoiceMessages/VoiceMessageRoomTimelineView.swift 0.00% 4 Missing ⚠️
...View/TimelineItemViews/VideoRoomTimelineView.swift 25.00% 3 Missing ⚠️
...X/Sources/Screens/Timeline/TimelineViewModel.swift 33.33% 2 Missing ⚠️
.../View/TimelineItemViews/FileRoomTimelineView.swift 60.00% 2 Missing ⚠️
...View/TimelineItemViews/ImageRoomTimelineView.swift 66.66% 2 Missing ⚠️
...w/TimelineItemViews/LocationRoomTimelineView.swift 33.33% 2 Missing ⚠️
...ew/TimelineItemViews/StickerRoomTimelineView.swift 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3553      +/-   ##
===========================================
- Coverage    78.59%   78.58%   -0.01%     
===========================================
  Files          757      757              
  Lines        63659    63679      +20     
===========================================
+ Hits         50034    50044      +10     
- Misses       13625    13635      +10     
Flag Coverage Δ
unittests 69.71% <59.52%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@stefanceriu stefanceriu added the pr-misc for other changes label Nov 26, 2024
@stefanceriu stefanceriu force-pushed the stefan/gestureShenanigans branch from dbb7dc0 to 3924c14 Compare November 26, 2024 12:50
@stefanceriu stefanceriu merged commit 3698084 into develop Nov 26, 2024
12 checks passed
@stefanceriu stefanceriu deleted the stefan/gestureShenanigans branch November 26, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants