-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move timeline item tap gestures to the items themselves instead of the bubbled styler #3553
Conversation
ElementX/Sources/Screens/Timeline/View/Style/TimelineItemBubbledStylerView.swift
Show resolved
Hide resolved
Generated by 🚫 Danger Swift against aeffce7 |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3553 +/- ##
===========================================
- Coverage 78.59% 78.58% -0.01%
===========================================
Files 757 757
Lines 63659 63679 +20
===========================================
+ Hits 50034 50044 +10
- Misses 13625 13635 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
ElementX/Sources/Screens/Timeline/View/TimelineItemViews/AudioRoomTimelineView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/Timeline/View/TimelineItemViews/AudioRoomTimelineView.swift
Outdated
Show resolved
Hide resolved
dbb7dc0
to
3924c14
Compare
Quality Gate passedIssues Measures |
While not much came out of the
UIGestureRecognizerRepresentable
prototypes we can at least move the normal tap to within the cells themselves. This will for example fix images opening in full screen when tapping on the caption text.