Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knock Requests banner display logic #3550

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Knock Requests banner display logic #3550

merged 3 commits into from
Nov 25, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 22, 2024 •
edited
Loading

This also updates the SDK to allow the join rule to be seen in the room info, since we only want to display the rquests when the join rule is knocking

Simulator.Screen.Recording.-.iPhone.16.-.2024-11-22.at.19.01.37.mp4

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 4449579

@codecov Codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
876 1 875 0
View the top 1 failed tests by shortest run time 
MediaUploadPreviewScreenViewModelTests testVideoUploadWithCaption()
Stack Traces | 11.4s run time 
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@Velin92 Velin92 added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Nov 22, 2024
@Velin92 Velin92 marked this pull request as ready for review November 22, 2024 18:04
@Velin92 Velin92 requested a review from a team as a code owner November 22, 2024 18:04
@Velin92 Velin92 requested review from pixlwave and stefanceriu and removed request for a team and pixlwave November 22, 2024 18:04
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.8% Duplication on New Code

See analysis details on SonarQube Cloud

pixlwave
pixlwave approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏

ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift Show resolved Hide resolved
ElementX/Sources/Screens/RoomScreen/View/RoomScreen.swift Show resolved Hide resolved
stefanceriu
stefanceriu approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lgtm! 👍

ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift Show resolved Hide resolved
@Velin92 Velin92 merged commit 26e07f2 into develop Nov 25, 2024
9 checks passed
@Velin92 Velin92 deleted the mauroromito/use_join_rule_in_info branch November 25, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees
No one assigned
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Velin92 @stefanceriu @pixlwave