-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for adding/editing/removing media captions. #3547
Conversation
Generated by 🚫 Danger Swift against b8f2a1e |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3547 +/- ##
===========================================
- Coverage 78.86% 78.74% -0.12%
===========================================
Files 751 751
Lines 63152 63227 +75
===========================================
- Hits 49802 49788 -14
- Misses 13350 13439 +89
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change of plan: Going to add captions to file items and support copying captions and then I'll UI test it all. |
Quality Gate passedIssues Measures |
Does what it says on the tin. Might add some more tests to this before merging, but we don't have anything around the
TimelineItemMenuActionProvider
right now.Closes #3509.
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-21.at.16.10.40.mp4