Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sharing URLs and text. #3546

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Conversation

pixlwave
Copy link
Member

This PR makes the following changes:

  • Add URL/Text as supported types in the share extension
  • Fall back to loading a URL and then a string in the share extension
  • Send both of these into the composer for the user to confirm before sending.
  • If sharing starts a new flow we pass the initial text in the init, otherwise it is set into the existing composer.
ScreenRecording_11-21-2024.1-51-23.pm_1.MP4

@pixlwave pixlwave requested a review from a team as a code owner November 21, 2024 13:55
@pixlwave pixlwave requested review from stefanceriu and removed request for a team November 21, 2024 13:55
Copy link

github-actions bot commented Nov 21, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against e6d2ae7

@pixlwave pixlwave added the pr-change for updates to an existing feature label Nov 21, 2024
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo, I love how clean this turned out!

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 85.49223% with 28 lines in your changes missing coverage. Please review.

Project coverage is 78.78%. Comparing base (3a9f54a) to head (e6d2ae7).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...entX/Sources/Other/Extensions/NSItemProvider.swift 0.00% 11 Missing ⚠️
...tension/Sources/ShareExtensionViewController.swift 0.00% 10 Missing ⚠️
...tTests/Sources/ComposerToolbarViewModelTests.swift 88.09% 5 Missing ⚠️
.../FlowCoordinators/UserSessionFlowCoordinator.swift 77.77% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3546      +/-   ##
===========================================
- Coverage    78.81%   78.78%   -0.04%     
===========================================
  Files          750      751       +1     
  Lines        63039    63152     +113     
===========================================
+ Hits         49686    49754      +68     
- Misses       13353    13398      +45     
Flag Coverage Δ
unittests 69.80% <85.49%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pixlwave pixlwave merged commit c081e53 into develop Nov 21, 2024
11 checks passed
@pixlwave pixlwave deleted the doug/text-based-sharing branch November 21, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants