Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the SDK. #3545

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Update the SDK. #3545

merged 1 commit into from
Nov 21, 2024

Conversation

pixlwave
Copy link
Member

Go back from a pinned commit to a release that uses dynamic linking.

@pixlwave pixlwave requested a review from a team as a code owner November 21, 2024 13:27
@pixlwave pixlwave requested review from Velin92 and removed request for a team November 21, 2024 13:27
@pixlwave pixlwave added the pr-misc for other changes label Nov 21, 2024
@pixlwave pixlwave merged commit 3a9f54a into develop Nov 21, 2024
7 checks passed
@pixlwave pixlwave deleted the doug/sdk branch November 21, 2024 13:28
@github-actions GitHub Actions
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against a2b2e88

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
870 1 869 0
View the top 1 failed tests by shortest run time 
ComposerToolbarViewModelTests testRestoreNormalPlainTextMessage()
Stack Traces | 0.852s run time 
XCTAssertEqual failed: ("") is not equal to ("Hello world!{
}") (.../UnitTests/Sources/ComposerToolbarViewModelTests.swift:363)

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

@Velin92 Velin92 Awaiting requested review from Velin92 Velin92 is a code owner automatically assigned from element-hq/element-x-ios-reviewers

Assignees
No one assigned
Labels
pr-misc for other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pixlwave @stefanceriu