Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI tests, update compound to roll back snapshot testing and avoid the requirement for Swift Testing. #3540

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-misc for other changes label Nov 20, 2024
@stefanceriu stefanceriu requested a review from pixlwave November 20, 2024 09:50
@stefanceriu stefanceriu requested a review from a team as a code owner November 20, 2024 09:50
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See you later weird dependencies.

Copy link

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against f43d1cc

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.75%. Comparing base (51227ff) to head (f43d1cc).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3540   +/-   ##
========================================
  Coverage    78.75%   78.75%           
========================================
  Files          750      750           
  Lines        63010    63010           
========================================
  Hits         49624    49624           
  Misses       13386    13386           
Flag Coverage Δ
unittests 69.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu merged commit 5eb42eb into develop Nov 20, 2024
13 checks passed
@stefanceriu stefanceriu deleted the stefan/fixUITestsPartDos branch November 20, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants