Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show both defaults and frequent emojis in the timeline item menu, make the list scrollable #3534

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-feature for a new feature label Nov 19, 2024
@stefanceriu stefanceriu requested a review from pixlwave November 19, 2024 15:27
@stefanceriu stefanceriu requested a review from a team as a code owner November 19, 2024 15:27
Copy link

github-actions bot commented Nov 19, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 21e9c55

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Might be some snapshots to update though :)

Comment on lines +50 to +51
// Frequently used emojis on the all use the same .heart SFSymbol.
// Override equatable so we can remove duplicates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm just waiting for the other shoe to drop 🙈

Copy link

codecov bot commented Nov 19, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
870 1 869 0
View the top 1 failed tests by shortest run time
PreviewTests test_roomMembersListScreen()
Stack Traces | 7.12s run time
failed - Snapshot "Member" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMembersListScreen-iPhone-16-en-GB.Member.png"
@+
"file:.../tmp/PreviewTests/test_roomMembersListScreen-iPhone-16-en-GB.Member.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.96676636 is less than required 1.0
The lowest perceptual color precision 0.148125 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@stefanceriu stefanceriu merged commit 51227ff into develop Nov 19, 2024
11 checks passed
@stefanceriu stefanceriu deleted the stefan/frequentEmojiTweaks branch November 19, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants