Knock Requests List Screen #3533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into mauroromito/knock_requests_list_screen # Conflicts: # ElementX.xcodeproj/project.pbxproj
so that the buttons that do not have permissions won't show
Generated by 🚫 Danger Swift against 6b00b9b |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3533 +/- ##
===========================================
- Coverage 78.73% 78.71% -0.03%
===========================================
Files 751 757 +6
Lines 63227 63486 +259
===========================================
+ Hits 49784 49971 +187
- Misses 13443 13515 +72
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…into mauroromito/knock_requests_list_screen
Velin92
added
the
pr-wip
…into mauroromito/knock_requests_list_screen
pixlwave
approved these changes
Nov 21, 2024
ElementX/Sources/Screens/KnockRequestsListScreen/KnockRequestsListScreenViewModel.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/KnockRequestsListScreen/View/KnockRequestCell.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/KnockRequestsListScreen/View/KnockRequestCell.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/KnockRequestsListScreen/View/KnockRequestCell.swift
Outdated
Show resolved
Hide resolved
PreviewTests/Sources/__Snapshots__/PreviewTests/test_knockRequestCell-iPad-en-GB.No-Ban.png
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/KnockRequestsListScreen/View/KnockRequestsListScreen.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/KnockRequestsListScreen/View/KnockRequestCell.swift
Show resolved
Hide resolved
…into mauroromito/knock_requests_list_screen
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thi adds the UI for the knock requests list screen and some other small improvements, to the existing UI, however this is jsut UI work, the business logic is not ready yet.